Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix linting issues in main,benchmark, and generate #33

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

AlishChhetri
Copy link
Collaborator

Description

Changes made to address the linting issues presented in issue #32

Fixes #32

Type of change

Please delete options that are not relevant.

  • [x ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please briefly write the names of the added tests to test your functionality.

Ran poetry run task lint to test this change

  • [x ] This PR does not need tested

@simojo
Copy link
Collaborator

simojo commented Apr 29, 2024

This doesn't necessarily fix #32 if there are still lingering linting errors. Would you rather remove the "Fixes #..." from the description or fix all the errors in this PR? Sorry for the matter-of-fact response.. 🥲

rebekahrudd
rebekahrudd previously approved these changes Apr 29, 2024
Copy link
Collaborator

@rebekahrudd rebekahrudd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assorted Linting Errors
4 participants